[PATCH] D87744: [RegisterCoalescer] passs Undefs to extendToIndices()

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 23:42:26 PDT 2020


ruiling created this revision.
ruiling added reviewers: kparzysz, arsenm, qcolombet, wmi.
Herald added subscribers: llvm-commits, kerbowa, tpr, hiraditya, nhaehnle, jvesely, MatzeB.
Herald added a project: LLVM.
ruiling requested review of this revision.
Herald added a subscriber: wdng.

When extending the subranges, the reaching-def may be an undefs. When
extending such kind of subrange, it will try to search for the reaching
def first. If the reaching def is an undef and we did not provide 'Undefs',
The findReachingDefs() will fail with message:
"Use of $noreg does not have a corresponding definition on every path:
 LLVM ERROR: Use not jointly dominated by defs."
So we computeSubRangeUndefs() and pass the result to extendToIndices().


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87744

Files:
  llvm/lib/CodeGen/RegisterCoalescer.cpp
  llvm/test/CodeGen/AMDGPU/coalescer-removepartial-extend-undef-subrange.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87744.292120.patch
Type: text/x-patch
Size: 11653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200916/e98fa0c3/attachment.bin>


More information about the llvm-commits mailing list