[llvm] 12a281d - [gn] Remove unneeded MC dep from llvm-tblgen

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 18:28:59 PDT 2020


Author: Reid Kleckner
Date: 2020-09-11T18:28:49-07:00
New Revision: 12a281d368e3ae115b2340c45f93b62e20759811

URL: https://github.com/llvm/llvm-project/commit/12a281d368e3ae115b2340c45f93b62e20759811
DIFF: https://github.com/llvm/llvm-project/commit/12a281d368e3ae115b2340c45f93b62e20759811.diff

LOG: [gn] Remove unneeded MC dep from llvm-tblgen

Tablegen does not have link time dependencies on MC. Having llvm-tblgen
depend on it causes it to be rebuilt in the gn build every time somebody
touches any cpp file in llvm/lib/MC* or llvm/lib/DebugInfo/Codeview*.
Touching tablegen invalidates most of the rest of the build, and
re-running it takes a while. This is is annoying for me when swapping
between branches that touch CodeView logic.

This dep was added to LLVMBuild.txt back in 2018, and presumably it was
carried over into the gn build.

Differential Revision: https://reviews.llvm.org/D87553

Added: 
    

Modified: 
    llvm/utils/TableGen/LLVMBuild.txt
    llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn

Removed: 
    


################################################################################
diff  --git a/llvm/utils/TableGen/LLVMBuild.txt b/llvm/utils/TableGen/LLVMBuild.txt
index 5eec4e060be5..6293aa0e4024 100644
--- a/llvm/utils/TableGen/LLVMBuild.txt
+++ b/llvm/utils/TableGen/LLVMBuild.txt
@@ -18,4 +18,4 @@
 type = BuildTool
 name = tblgen
 parent = BuildTools
-required_libraries = Support TableGen MC
+required_libraries = Support TableGen

diff  --git a/llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn b/llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn
index 4559926899c9..bd1382d4def7 100644
--- a/llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn
+++ b/llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn
@@ -1,7 +1,6 @@
 executable("llvm-tblgen") {
   deps = [
     "//llvm/include/llvm/Config:llvm-config",
-    "//llvm/lib/MC",
     "//llvm/lib/Support",
     "//llvm/lib/TableGen",
     "//llvm/utils/TableGen/GlobalISel",


        


More information about the llvm-commits mailing list