[PATCH] D87476: [libFuzzer] Enable entropic by default.

[Max Moroz via Phabricator via llvm-commits]

Dor1s added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:771
+  if (!Options.FocusFunction.empty())
+    Options.Entropic = false; // FocusFunction overrides entropic scheduling.
+  if (Options.Entropic)
----------------
morehouse wrote:
> Dor1s wrote:
> > maybe we should preserve an explicit error in case both focus function and entropic are used? Otherwise it's not obvious and might be even tricky to realize without checking libFuzzer's source code.
> The reason I took the error out is to avoid `-focus-function` requiring two flags to use now (i.e. `-entropic=0 -focus_function=auto`).
> 
> I figured it doesn't make much sense to use `focus_function` with entropic anyway, since `-focus_function` is essentially its own scheduling algorithm.
Ah, that's right, as now we'd need to disable it explicitly. Let's update the `focus_function` doc string in such case, pointing out that it disables entropic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87476/new/

https://reviews.llvm.org/D87476