[PATCH] D87476: [libFuzzer] Enable entropic by default.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 12:02:53 PDT 2020


morehouse added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:771
+  if (!Options.FocusFunction.empty())
+    Options.Entropic = false; // FocusFunction overrides entropic scheduling.
+  if (Options.Entropic)
----------------
Dor1s wrote:
> maybe we should preserve an explicit error in case both focus function and entropic are used? Otherwise it's not obvious and might be even tricky to realize without checking libFuzzer's source code.
The reason I took the error out is to avoid `-focus-function` requiring two flags to use now (i.e. `-entropic=0 -focus_function=auto`).

I figured it doesn't make much sense to use `focus_function` with entropic anyway, since `-focus_function` is essentially its own scheduling algorithm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87476/new/

https://reviews.llvm.org/D87476



More information about the llvm-commits mailing list