[PATCH] D87351: AMDGPU/GlobalISel/Emitter Recognize additional 'same operand checks'

[Petar Avramovic via Phabricator via llvm-commits]

Petar.Avramovic updated this revision to Diff 290687.
Petar.Avramovic added a reviewer: paquette.
Petar.Avramovic added a comment.

Show how this emitter change affects isel, and update tablegen tests.
Add additional checks for complex suboperands for test added in D57980 <https://reviews.llvm.org/D57980>. Neither tablegen nor sdag have check for such pattern and it looks like an error to me (there is no way for tablegen to know that some c++ code that generates two operands will generate same operand x (first out operand) from different input operands - these are operand 1 and 2 of G_ADD instruction). Also, if I checked correctly, there were no patterns like that in llvm upstream.  Skip such patterns anyway in GlobalIselEmitter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87351/new/

https://reviews.llvm.org/D87351

Files:
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fract.f64.mir
  llvm/test/TableGen/GlobalISelEmitter.td
  llvm/test/TableGen/GlobalISelEmitterSkippedPatterns.td
  llvm/utils/TableGen/GlobalISelEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87351.290687.patch
Type: text/x-patch
Size: 7853 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200909/0741eadb/attachment.bin>