[PATCH] D86839: [CMake] Remove -Wl,-allow-shlib-undefined which was added in rL221530

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 21:14:23 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc6734020844: [CMake] Remove -Wl,-allow-shlib-undefined which was added in rL221530 (authored by MaskRay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86839/new/

https://reviews.llvm.org/D86839

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -969,16 +969,6 @@
           add_definitions("-D_FILE_OFFSET_BITS=64")
 endif()
 
-# Work around a broken bfd ld behavior. When linking a binary with a
-# foo.so library, it will try to find any library that foo.so uses and
-# check its symbols. This is wasteful (the check was done when foo.so
-# was created) and can fail since it is not the dynamic linker and
-# doesn't know how to handle search paths correctly.
-if (UNIX AND NOT APPLE AND NOT CMAKE_SYSTEM_NAME MATCHES "SunOS|AIX|OS390")
-  set(CMAKE_EXE_LINKER_FLAGS
-      "${CMAKE_EXE_LINKER_FLAGS} -Wl,-allow-shlib-undefined")
-endif()
-
 set(CMAKE_INCLUDE_CURRENT_DIR ON)
 
 include_directories( ${LLVM_INCLUDE_DIR} ${LLVM_MAIN_INCLUDE_DIR})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86839.289348.patch
Type: text/x-patch
Size: 849 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200902/ab1ffb23/attachment.bin>


More information about the llvm-commits mailing list