[PATCH] D86839: [CMake] Remove -Wl,-allow-shlib-undefined which was added in rL221530

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 20:54:23 PDT 2020


MaskRay added a comment.

In D86839#2251137 <https://reviews.llvm.org/D86839#2251137>, @dcaballe wrote:

> Thanks for the patch! I can confirm that it is fixing our build locally (using gcc 7.5.0).

Thanks for testing, and

In D86839#2251251 <https://reviews.llvm.org/D86839#2251251>, @echristo wrote:

> I think this is the right thing to do here. In addition, we should not cherry pick this to any release branch so we have the opportunity to get it more fully evaluated by distros/vendors/etc over the next months.

thanks for the additional approval power!

(I am pretty confident that nothing will go off. We use -z defs as well, which is a strictly stronger guarantee than --allow-shlib-undefined.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86839/new/

https://reviews.llvm.org/D86839



More information about the llvm-commits mailing list