[PATCH] D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available

Tue Aug 25 07:28:01 PDT 2020

aganea added a comment.

In D86496#2236188 <https://reviews.llvm.org/D86496#2236188>, @thakis wrote:

> In D86496#2235124 <https://reviews.llvm.org/D86496#2235124>, @aganea wrote:
>
>> @thakis Do you think you can add `printenv.exe` into https://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-XX.zip so we can enable the test again on Windows? Please see https://reviews.llvm.org/D86170#inline-799301
>
> We have `env` as a lit builtin. Can we just use that? What's the `not --crash` supposed to do here? Why would env crash anyway? I miss context on what this test wants to do.

I was under the false impression yesterday that the local `env.exe` (found in GnuWin32) wouldn't print the environment block, but it does. It seems the problem lies in how the commands are interpreted by lit. On Windows, with this test, we reach this: https://github.com/llvm/llvm-project/blob/master/llvm/utils/lit/lit/TestRunner.py#L645 - but on not Linux?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86496/new/

https://reviews.llvm.org/D86496