[PATCH] D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 07:01:28 PDT 2020


thakis added a comment.

In D86496#2235124 <https://reviews.llvm.org/D86496#2235124>, @aganea wrote:

> @thakis Do you think you can add `printenv.exe` into https://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-XX.zip so we can enable the test again on Windows? Please see https://reviews.llvm.org/D86170#inline-799301

We have `env` as a lit builtin. Can we just use that? What's the `not --crash` supposed to do here? Why would env crash anyway? I miss context on what this test wants to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86496/new/

https://reviews.llvm.org/D86496



More information about the llvm-commits mailing list