[PATCH] D86134: Fix OCaml build failure because of absolute path in system libs

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D86134#2226975 <https://reviews.llvm.org/D86134#2226975>, @aeubanks wrote:

> In D86134#2226701 <https://reviews.llvm.org/D86134#2226701>, @phosek wrote:
>
>> @haampie I landed your change but I'm seeing the following failure on sanitizer Windows bot:
>>
>>   CMake Error at lib/Support/CMakeLists.txt:223 (get_system_libname):
>>     get_system_libname Function invoked with incorrect arguments for function
>>     named: get_system_libname
>>
>> The failing build is http://lab.llvm.org:8011/builders/sanitizer-windows/builds/68331
>>
>> I'm going to revert the change, but I'm happy to reland it once we figure out what the problem is.
>
> I also think this broke the Windows builds for Chrome: https://crbug.com/1119478.
> CMake Error at lib/Support/CMakeLists.txt:9 (STRING):
>
>   STRING sub-command REGEX, mode REPLACE: regex "^()" matched an empty
>   string.
>
> Call Stack (most recent call first):
>
>   lib/Support/CMakeLists.txt:218 (get_system_libname)
>
> Might need zlib to repro.

I've addressed the terminfo issue with D86234 <https://reviews.llvm.org/D86234>, I can look into the zlib issue.



================
Comment at: llvm/lib/Support/CMakeLists.txt:222
 
+if(LLVM_ENABLE_TERMINFO)
+  get_system_libname(${TERMINFO_LIB} terminfo_library)
----------------
We might need to gate this block on `CMAKE_HOST_UNIX` just like we do above, but I'm also a bit surprised that `LLVM_ENABLE_TERMINFO` is `TRUE` on Windows?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86134/new/

https://reviews.llvm.org/D86134