[PATCH] D86134: Fix OCaml build failure because of absolute path in system libs

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 13:09:32 PDT 2020


aeubanks added a comment.

In D86134#2226701 <https://reviews.llvm.org/D86134#2226701>, @phosek wrote:

> @haampie I landed your change but I'm seeing the following failure on sanitizer Windows bot:
>
>   CMake Error at lib/Support/CMakeLists.txt:223 (get_system_libname):
>     get_system_libname Function invoked with incorrect arguments for function
>     named: get_system_libname
>
> The failing build is http://lab.llvm.org:8011/builders/sanitizer-windows/builds/68331
>
> I'm going to revert the change, but I'm happy to reland it once we figure out what the problem is.

I also think this broke the Windows builds for Chrome: https://crbug.com/1119478.
CMake Error at lib/Support/CMakeLists.txt:9 (STRING):

  STRING sub-command REGEX, mode REPLACE: regex "^()" matched an empty
  string.

Call Stack (most recent call first):

  lib/Support/CMakeLists.txt:218 (get_system_libname)

Might need zlib to repro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86134/new/

https://reviews.llvm.org/D86134



More information about the llvm-commits mailing list