[PATCH] D83884: GlobalISel: Make type for lower action more consistently optional

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4381
     // Ref: "Hacker's Delight" by Henry Warren
-    auto MIBCstNeg1 = MIRBuilder.buildConstant(Ty, -1);
-    auto MIBNot = MIRBuilder.buildXor(Ty, SrcReg, MIBCstNeg1);
----------------
aemerson wrote:
> These changes look orthogonal to the main patch?
No, this switches from using the type parameter (which was sometimes invalid) to taking the types from the register operands. This was also incorrectly assuming the result type and the source type were the same


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83884/new/

https://reviews.llvm.org/D83884