[PATCH] D83884: GlobalISel: Make type for lower action more consistently optional

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2330
 LegalizerHelper::LegalizeResult
-LegalizerHelper::lower(MachineInstr &MI, unsigned TypeIdx, LLT Ty) {
+LegalizerHelper::lower(MachineInstr &MI, unsigned TypeIdx, LLT LowerTy) {
   using namespace TargetOpcode;
----------------
I suggest renaming this to something like LowerHintTy to make it clear it.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4381
     // Ref: "Hacker's Delight" by Henry Warren
-    auto MIBCstNeg1 = MIRBuilder.buildConstant(Ty, -1);
-    auto MIBNot = MIRBuilder.buildXor(Ty, SrcReg, MIBCstNeg1);
----------------
These changes look orthogonal to the main patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83884/new/

https://reviews.llvm.org/D83884