[PATCH] D86052: [clangd] Fix Windows build when remote index is enabled.

[Aleksandr Platonov via Phabricator via llvm-commits]

ArcsinX added a comment.

In D86052#2221179 <https://reviews.llvm.org/D86052#2221179>, @kbobyrev wrote:

> Looks good to me, thank you very much!
>
> I'm curious why this works on Linux though, I guess `Threads` are not aliased as `Threads::Threads` somehow?
>
> I assume you are able to build this on Windows with this patch, right?

Yes.

> That's really cool, thank you for trying it out! I plan to add Windows support in the following month or so and add some tests so that it is continuously build on the buildbots but I'll need to get a Windows machine first and learn some of its specifics :D

I have tried the following scenario (index for LLVM project):

- `clangd` on Windows
- `clangd-index-server` on Linux

It works mostly well, but for obvious reasons I see these messages in `clangd-index-server` log:

  E[11:13:37.051] Unable to convert Symbol to protobuf: File path '/usr/include/wctype.h' doesn't start with '/home/test/work/llvm-project/'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86052/new/

https://reviews.llvm.org/D86052