[PATCH] D86052: [clangd] Fix Windows build when remote index is enabled.

Kirill Bobyrev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 06:11:50 PDT 2020


kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

Looks good to me, thank you very much!

I'm curious why this works on Linux though, I guess `Threads` are not aliased as `Threads::Threads` somehow?

I assume you are able to build this on Windows with this patch, right? That's really cool, thank you for trying it out! I plan to add Windows support in the following month or so and add some tests so that it is continuously build on the buildbots but I'll need to get a Windows machine first and learn some of its specifics :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86052/new/

https://reviews.llvm.org/D86052



More information about the llvm-commits mailing list