[PATCH] D75954: Cache uwnind frame headers as they are found.

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 16 12:51:52 PDT 2020


saugustine added a comment.

In D75954#2219870 <https://reviews.llvm.org/D75954#2219870>, @dim wrote:

> It looks like the need for some locking in this `FrameHeaderCache` was completely overlooked? Or at least, having a cache per thread would make locking unnecessary, but it would cost more memory.

Well, not _completely_ overlooked. Looks like glibc locks things and other libc's don't. Should be easy to add a lock here for non glibc targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75954/new/

https://reviews.llvm.org/D75954



More information about the llvm-commits mailing list