[PATCH] D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset.

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 10:14:12 PDT 2020


ZarkoCA added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:1547
   // Get the ABI.
   bool isSVR4ABI = Subtarget.isSVR4ABI();
 
----------------
I'm pretty sure this variable is no longer needed.  


================
Comment at: llvm/test/CodeGen/PowerPC/aix-base-pointer.ll:13
 
-define void @caller() {
   %AlignedBuffer = alloca [32 x i32], align 32
----------------
Just a question: is this test maybe good to have as it is to show behaviour for a void return? 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85850/new/

https://reviews.llvm.org/D85850



More information about the llvm-commits mailing list