[PATCH] D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset.

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 08:31:17 PDT 2020


Xiangling_L added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-framepointer-save-restore.ll:2
+; RUN: llc -verify-machineinstrs < %s -mcpu=pwr4 -mattr=-altivec \
+; RUN: -mtriple=powerpc-ibm-aix-xcoff -frame-pointer=all | FileCheck %s \
+; RUN: -check-prefix=AIX32
----------------
Since you have a variable `n` here, I believe we've already had some testcases making sure frame pointer will definitely be used in this scenario, you can remove `-frame-pointer=all`. But I am okay if you want to keep it just in case. And if so, should we also add on for below 64bit case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85850/new/

https://reviews.llvm.org/D85850



More information about the llvm-commits mailing list