[PATCH] D84449: AMDGPU/GlobalISel: Manually select llvm.amdgcn.writelane

Tue Aug 11 08:48:35 PDT 2020

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

In D84449#2210301 <https://reviews.llvm.org/D84449#2210301>, @arsenm wrote:

> In D84449#2210208 <https://reviews.llvm.org/D84449#2210208>, @foad wrote:
>
>> Pre-gfx10 `writelane v0, m0, s0` is legal, isn't it? Does your implementation allow for that? You don't seem to have any tests for that case.
>
> This is covered by @test_writelane_m0_s_v, but it looks like it ends up swapping the registers:
>
>   ; GFX7-NEXT:    s_mov_b32 s0, m0
>   ; GFX7-NEXT:    s_mov_b32 m0, s2
>   ; GFX7-NEXT:    v_writelane_b32 v0, s0, m0

I guess it's probably not worth worrying about this case? It all looks functionally correct anyway.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84449/new/

https://reviews.llvm.org/D84449