[PATCH] D85585: Replace TableGen range piece punctuator with '..'

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 17:00:31 PDT 2020


dblaikie added a comment.

I'm by no means a decider here - I haven't written tablegen files (except the really basic ones in Clang) & certainly don't maintain it in any way - just my 2c that maybe this isn't worth it if it's not going to remove the old one? (& even then, I imagine the documentation for the current behavior could be written in a way that still essentially describes the behavior users rely on (if it was written as "integer - integer" do you think anyone would care that that's not how it's lexed and that they couldn't write "-5--3"? Especially since negative values aren't allowed anyway) & not be particularly confusing/problematic?)

But I'll leave it to folks with more tablegen context to hash this out - just figured I might be able to get the ball rolling a bit in the mean time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85585/new/

https://reviews.llvm.org/D85585



More information about the llvm-commits mailing list