[PATCH] D85585: Replace TableGen range piece punctuator with '..'

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 16:54:32 PDT 2020


Paul-C-Anagnostopoulos added a comment.

Even though the old syntax would be deprecated, I think it still needs to be in the documentation. I'm writing a new Programmer's Reference and would be happy to eliminate it, but that doesn't seem right. However, it might make sense to separate the two productions and put them with the deprecation warning, in order to help clean up the documentation. Or even make them a footnote.

The code is rather convoluted, because the lexer lexes '0-5' as '0' and '-5'. This is because leading signs are lexed as part of the integer rather than as unary operators. But it also has to handle '0-+5', which is lexed as '0', '-', and '+5'.

You could invalidate the second form, but then the code would have to check for it and complain, so nothing would be gained.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85585/new/

https://reviews.llvm.org/D85585



More information about the llvm-commits mailing list