[PATCH] D85691: lld: link libatomic if needed for Timer

Josh Stone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 16:11:15 PDT 2020


cuviper added a comment.

@jfb You did see that this is only for `NOT HAVE_CXX_ATOMICS64_WITHOUT_LIB`, right? So I'm only adding that link (and hidden locking) for targets that can't do 64-bit atomics natively, otherwise you get link errors like this Rust CI failure on arm <https://github.com/rust-lang/rust/pull/73526#issuecomment-671549737>. This kind of conditional `atomic` link exists in several places in the monorepo already.

It makes sense to me for Timer to use a 64-bit atomic, whether native or emulated, but I'll defer to @rnk as the author on that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85691/new/

https://reviews.llvm.org/D85691



More information about the llvm-commits mailing list