[PATCH] D83834: Add test utility 'split-file'

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In D83834#2208178 <https://reviews.llvm.org/D83834#2208178>, @MaskRay wrote:

> In D83834#2208107 <https://reviews.llvm.org/D83834#2208107>, @ro wrote:
>
>> 



> std::errc::directory_not_empty is intentionally excluded. What error code is it on Solaris?
>
>   if (std::error_code ec = sys::fs::remove(output, /*IgnoreNonExisting=*/true))
>     if (ec.value() != static_cast<int>(std::errc::directory_not_empty))
>       fatal(output, ec.message());

On Solaris it's `EEXIST`/`file_exists`, as documented on the Solaris `rmdir(2)` man page and explicitly allowed by POSIX/XPG7 <https://pubs.opengroup.org/onlinepubs/9699919799/toc.htm>:

  [EEXIST] or [ENOTEMPTY]
      The path argument names a directory that is not an empty directory, or there are hard links to the directory other than dot or a single entry in dot-dot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834