[PATCH] D85519: [llvm-readobj/elf] - Refine the code for broken PT_DYNAMIC segment diagnostic.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 01:52:56 PDT 2020


jhenderson added a comment.

Maybe it would be a good idea to split this change in two - one to update the test, and the other to change the behaviour - to ensure we don't accidentally break something in the test and behaviour at the same time. What do you think?



================
Comment at: llvm/test/tools/llvm-readobj/ELF/malformed-pt-dynamic.test:68-69
       - Section: .dynamic
+SectionHeaderTable:
+  NoHeaders: true
----------------
Do we actually need to strip the section headers any more? I'm not sure the original issue really applies any more, as it was just to do with yaml2obj's previous limitations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85519/new/

https://reviews.llvm.org/D85519



More information about the llvm-commits mailing list