[PATCH] D85688: [InstSimplify][test] Remove unintended undef in vscale.ll

Huihui Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 14:17:00 PDT 2020


huihuiz added a comment.

> I don't think that's the intention of this specific test given the name `insert_extract_element_same_vec_idx_2`. And also the unused parameter `%a`.
> This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?

The "same_vec_idx" refer to index "i64 4" , that's where the extractelement is extracting.
You can remove %a from function argument, that's added in error.

I think the undef should be kept. 
Checking sequence insert+extract on a vector, being a existing vector, or under shouldn't matter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85688/new/

https://reviews.llvm.org/D85688



More information about the llvm-commits mailing list