[PATCH] D85688: [InstSimplify][test] Remove unintended undef in vscale.ll

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 14:10:57 PDT 2020


aeubanks added a comment.

In D85688#2208127 <https://reviews.llvm.org/D85688#2208127>, @huihuiz wrote:

> why do we need this change? 
> insert element into undef is common to construct a vector, being fixed or scalable.

I don't think that's the intention of this specific test given the name `insert_extract_element_same_vec_idx_2`. And also the unused parameter `%a`.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85688/new/

https://reviews.llvm.org/D85688



More information about the llvm-commits mailing list