[PATCH] D54749: Saturating float to int casts: Basics [1/n]

[Bevin Hansson via Phabricator via llvm-commits]

ebevhan added a comment.

In D54749#2206737 <https://reviews.llvm.org/D54749#2206737>, @spatel wrote:

> In D54749#2206518 <https://reviews.llvm.org/D54749#2206518>, @ebevhan wrote:
>
>> It seems like there are quite a few people who would like to use this intrinsic, though. The only lack of interest seems to be in reviewing. 
>> I was planning on submitting something similar for the fixed-point support, but now that I know this patch exists, I feel like helping this move forward is the better option.
>
> That seems like the right way to proceed (commandeer/reopen) - there was definitely interest from the early reviewer comments, but maybe they're tied up with other stuff, so just add more people to the list.
> Personally, I didn't look at this closely because I had higher priority patches and I thought other reviewers would continue. I don't think there are any fundamental blockers. Sometimes you just have to keep pinging. :)

Well, I suspect that the GIsel people will want a GIsel lowering of the intrinsics to match the ISelDAG ones, but other than that the patch looks good from what I can see.

I will probably commandeer this soon and try for another push at getting it in if @nikic doesn't mind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749