[PATCH] D54749: Saturating float to int casts: Basics [1/n]

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 07:22:43 PDT 2020


spatel added a comment.

In D54749#2206518 <https://reviews.llvm.org/D54749#2206518>, @ebevhan wrote:

> It seems like there are quite a few people who would like to use this intrinsic, though. The only lack of interest seems to be in reviewing. 
> I was planning on submitting something similar for the fixed-point support, but now that I know this patch exists, I feel like helping this move forward is the better option.

That seems like the right way to proceed (commandeer/reopen) - there was definitely interest from the early reviewer comments, but maybe they're tied up with other stuff, so just add more people to the list.
Personally, I didn't look at this closely because I had higher priority patches and I thought other reviewers would continue. I don't think there are any fundamental blockers. Sometimes you just have to keep pinging. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749



More information about the llvm-commits mailing list