[PATCH] D85526: [llvm-readobj] - Refine program headers testing (`-l`, `--program-headers` and `--segment`).

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

There are a few typos in the description: `--segment` -> `--segments`

> Merges program-headers.test and pt-gnu-property.test to gnu-phdrs.test.
>
> Removes 2 precompiled binaries used by program-headers.test (other ones are still used by another tests).

Makes sense. Thanks!

Except that.... program-headers.test has some llvm-readobj RUN lines. Note that we still need some representative tests for the LLVM style.

> I am also not sure if we want to rename gnu-phdrs.test to something (e.g to program-headers.test) in this patch or is it better to do in a "NFC" follow-up? (for better commit history and to avoid confusion).

Do you want to add some llvm-readobj RUN lines to gnu-phdrs.test so that it will become a misnomer to call the test `gnu-*`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85526/new/

https://reviews.llvm.org/D85526