[PATCH] D85526: [llvm-readobj] - Refine program headers testing (`-l`, `--program-headers` and `--segment`).

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, atanasyan, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar requested review of this revision.

We have `gnu-phdrs.test` that tests
`-l`, `--program-headers` and `--segment` options for `llvm-readelf`.

We also have:

1. `program-headers.test` that tests `--program-headers` and `-l` for `llvm-readobj`. It doesn't test `--segment` and also uses lots of precompiled objects. It is very incomplete in compare with the `gnu-phdrs.test`.

2. `pt-gnu-property.test` that contains a simple test for the `PT_GNU_PROPERTY` segment. There is no reason to have it in a separate file.

This patch:

1. Merges `program-headers.test` and `pt-gnu-property.test` to `gnu-phdrs.test`.
2. Removes 2 precompiled binaries used by `program-headers.test` (other ones are still used by another tests).

I am also not sure if we want to rename `gnu-phdrs.test` to something (e.g to
`program-headers.test`) in this patch or is it better to do in a "NFC" follow-up?
(for better commit history and to avoid confusion).


https://reviews.llvm.org/D85526

Files:
  llvm/test/Object/Inputs/program-headers.mips
  llvm/test/Object/Inputs/program-headers.mips64
  llvm/test/tools/llvm-readobj/ELF/gnu-phdrs.test
  llvm/test/tools/llvm-readobj/ELF/program-headers.test
  llvm/test/tools/llvm-readobj/ELF/pt-gnu-property.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85526.283905.patch
Type: text/x-patch
Size: 27912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200807/7e3c3cd3/attachment.bin>