[PATCH] D85499: [X86] Canonicalize andnp for bitmask arithmetic

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Are you saying you think we can get away with removing X86ISD::ANDNP entirely? We don't have it for the BMI scalar variant, and it /usually/ works.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:39637
+    SDValue CastRHS = DAG.getBitcast(CondVT, RHS);
+    SDValue AndN = DAG.getNode(X86ISD::ANDNP, DL, CondVT, Cond, CastRHS);
     return DAG.getBitcast(VT, AndN);
----------------
This looks a separate NFC-ish change - a legacy from when the bitops were legal for just vXi64 types


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85499/new/

https://reviews.llvm.org/D85499