[PATCH] D84250: [InstSimplify] ExpandBinOp should fold an expression only when it's safe

[Eric Christopher via llvm-commits]

I think that we should revert the original patch for now since we have a
known miscompile and a chain of fixes are required to fix it.

As far as whether or not we can cause problems downstream from an
instcombine change - it's true, and unfortunately those need to be fixed
before we can have the instcombine as well if we find them.

Thanks!

On Thu, Aug 6, 2020 at 3:35 PM Kazu Hirata via Phabricator <
reviews at reviews.llvm.org> wrote:

> kazu added a comment.
>
> Friendly ping.
>
> Is there something left to improve in this patch?  I'm asking this because
> a fix for https://bugs.llvm.org/show_bug.cgi?id=46940 builds on this fix,
> so I'd like to see this patch checked in if there is no pending issues.
> Thanks!
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D84250/new/
>
> https://reviews.llvm.org/D84250
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200806/54ed554b/attachment.html>