[PATCH] D85279: [Coroutines] Use `Value::stripPointerCasts` to collect lifetime marker of `alloca` in CoroFrame

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 19:23:19 PDT 2020


ChuanqiXu added a comment.

In D85279#2195758 <https://reviews.llvm.org/D85279#2195758>, @junparser wrote:

> LGTM,Thank you, Please merge the testcases into one file.

It seems a little hard to merge the test cases into one file due to the order of function emitted by NewPassManager and LegacyPassManager is reverse. Although `CHECK-DAG` could match the string that don’t occur in a strictly sequential order, the string need to be checked in there test cases is dependent. Maybe there are some methods to merge the test cases, but I can't find these methods directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85279/new/

https://reviews.llvm.org/D85279



More information about the llvm-commits mailing list