[PATCH] D84923: [ARM] Fix so immediates and pc relative checks

[Diogo N. Sampaio via Phabricator via llvm-commits]

dnsampaio marked 2 inline comments as done.
dnsampaio added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1792
     // FIXME: Check if offset is multiple of scale if scale is not 4.
-    if (isCPEntryInRange(U.MI, UserOffset, U.CPEMI, MaxOffs, false, true)) {
+    if (isCPEntryInRange(U.MI, UserOffset, U.CPEMI, MaxOffs, false, true,
+                         true)) {
----------------
dmgreen wrote:
> I guess, should this be true?
Indeed, we are testing t1 coding here.


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/fast-fp-loops.ll:326
 ; CHECK-NEXT:    sub.w r12, r2, #1
-; CHECK-NEXT:    adr r2, .LCPI2_1
+; CHECK-NEXT:    adr.w r2, .LCPI2_1
 ; CHECK-NEXT:    movs r3, #0
----------------
dmgreen wrote:
> I've not looked into any of the details yet, but what's happening with these changes? I wouldn't expect any of them to be hitting the limit on a adr.
Were consequence of not performing the reduction, due the error below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84923/new/

https://reviews.llvm.org/D84923