[PATCH] D84923: [ARM] Fix so immediates and pc relative checks

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 06:49:03 PDT 2020


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1792
     // FIXME: Check if offset is multiple of scale if scale is not 4.
-    if (isCPEntryInRange(U.MI, UserOffset, U.CPEMI, MaxOffs, false, true)) {
+    if (isCPEntryInRange(U.MI, UserOffset, U.CPEMI, MaxOffs, false, true,
+                         true)) {
----------------
I guess, should this be true?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84923/new/

https://reviews.llvm.org/D84923



More information about the llvm-commits mailing list