[PATCH] D84927: [TargetPassConfig] Run MachineVerifier after more passes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 06:04:29 PDT 2020


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1176
 void TargetPassConfig::addOptimizedRegAlloc() {
-  addPass(&DetectDeadLanesID, false);
+  addPass(&DetectDeadLanesID);
 
----------------
I thought there were deeper problems here that prevented this, but it's great if that's not the case anymore


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1201
 
   addPass(&TwoAddressInstructionPassID, false);
   addPass(&RegisterCoalescerID);
----------------
I assume there's still a problem for TwoAddressInstructionPass?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84927/new/

https://reviews.llvm.org/D84927



More information about the llvm-commits mailing list