[PATCH] D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation

Tue Jul 28 13:27:27 PDT 2020

NeHuang added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:50
+
+class PPCPreEmitPeephole : public MachineFunctionPass {
+public:
----------------
nemanjai wrote:
> stefanp wrote:
> > nit:
> > I get the feeling that clang-format went a little crazy on this file and removed the indentation. :)
> > Should probably be a separate NFC patch.
> Yeah, I have no idea what `clang-format`'s problem is - why is it modifying lines that I never touched in this patch? I don't mind pre-committing an NFC patch from running `clang-format` on this file.
+1, It makes sense to have a separate NFC patch for `clang-format` changes. Phabricator complains those `clang-format` issues in https://reviews.llvm.org/D84360?id=279937 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84360/new/

https://reviews.llvm.org/D84360