[PATCH] D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 13:20:21 PDT 2020


NeHuang added inline comments.


================
Comment at: llvm/include/llvm/Target/PPCLegacyToPCRelMap.def:36
+enum PPC : uint64_t {
+  // Loads
+  PREFIX_MLS = 0x0610000000000000lu,
----------------
nit: `// Loads.`


================
Comment at: llvm/include/llvm/Target/PPCLegacyToPCRelMap.def:74
+
+  // Stores
+  STB = 38,
----------------
nit: `// Stores.`


================
Comment at: llvm/include/llvm/Target/PPCLegacyToPCRelMap.def:123
+    {PPC::LXV, ST_STX28_TO5},
+    {PPC::LXVP, ONLY_RST},
+    // Stores.
----------------
Do we also need to add a FIXME here for `PPC::LXVP` and `PPC::STXVP` since they are not supported yet?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84360/new/

https://reviews.llvm.org/D84360



More information about the llvm-commits mailing list