[PATCH] D84653: ARM: make Thumb1 instructions non-flag-setting in IT block.

[Dave Green via Phabricator via llvm-commits]

dmgreen added subscribers: NickGuy, dmgreen.
dmgreen added a comment.

This looks familiar, as something @NickGuy was looking at recently from D83667 <https://reviews.llvm.org/D83667>. We didn't know about ThumbArithFlagSetting though, that's a nice way to do it.

Can you update the comment from the CodeGen/ARM/thumb2-it-block.ll test too? The code here looks OK to me.



================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:547
+      unsigned OpNo;
+      for (OpNo = 0;
+           !MCID.OpInfo[OpNo].isOptionalDef() && OpNo < MCID.NumOperands;
----------------
It sounds OK to search, but will this always just be operand 1?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84653/new/

https://reviews.llvm.org/D84653