[PATCH] D84181: [GVN] Rewrite IsValueFullyAvailableInBlock()

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 04:10:58 PDT 2020


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks. Might be good to wait a day with committing, in case there are any additional concerns.



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:764
+  // If the block isn't marked as fixpoint yet
+  // (the Unavailable and Available states are fixpoints)
+  auto MarkAsFixpointAndEnqueueSuccessors =
----------------
nit: add period at end of sentence


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84181/new/

https://reviews.llvm.org/D84181





More information about the llvm-commits mailing list