[PATCH] D84181: [GVN] Rewrite IsValueFullyAvailableInBlock()

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 04:08:40 PDT 2020


lebedev.ri updated this revision to Diff 280851.
lebedev.ri marked 6 inline comments as done.
lebedev.ri added a comment.

Thank you for taking a look!

In D84181#2175234 <https://reviews.llvm.org/D84181#2175234>, @fhahn wrote:

> Thanks for the test case! I think this makes sense and is in the spirit of the original implementation, with some improvements. Some more comments, mostly related to wording inline.


Nits addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84181/new/

https://reviews.llvm.org/D84181

Files:
  llvm/lib/Transforms/Scalar/GVN.cpp
  llvm/test/Transforms/GVN/loadpre-missed-opportunity.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84181.280851.patch
Type: text/x-patch
Size: 13457 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200727/eaa52600/attachment.bin>


More information about the llvm-commits mailing list