[llvm] cf9fa2a - [lAA] Return SmallVectorImpl& instead of SmallVector& (NFC).

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 05:35:23 PDT 2020


On Wed, Jul 22, 2020 at 11:49 AM Roman Lebedev <lebedev.ri at gmail.com> wrote:

> On Wed, Jul 22, 2020 at 1:40 PM Florian Hahn via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> >
> > Author: Florian Hahn
> > Date: 2020-07-22T11:40:07+01:00
> > New Revision: cf9fa2aa018105313efc77c7fb6c5d9dce700297
> >
> > URL:
> https://github.com/llvm/llvm-project/commit/cf9fa2aa018105313efc77c7fb6c5d9dce700297
> > DIFF:
> https://github.com/llvm/llvm-project/commit/cf9fa2aa018105313efc77c7fb6c5d9dce700297.diff
> >
> > LOG: [lAA] Return SmallVectorImpl& instead of SmallVector& (NFC).
> >
> > Added:
> >
> >
> > Modified:
> >     llvm/include/llvm/Analysis/LoopAccessAnalysis.h
> >
> > Removed:
> >
> >
> >
> >
> ################################################################################
> > diff  --git a/llvm/include/llvm/Analysis/LoopAccessAnalysis.h
> b/llvm/include/llvm/Analysis/LoopAccessAnalysis.h
> > index a5237e9ba59e..663b9c9935db 100644
> > --- a/llvm/include/llvm/Analysis/LoopAccessAnalysis.h
> > +++ b/llvm/include/llvm/Analysis/LoopAccessAnalysis.h
> > @@ -418,7 +418,7 @@ class RuntimePointerChecking {
> >                        bool UseDependencies);
> >
> >    /// Returns the checks that generateChecks created.
> > -  const SmallVector<RuntimePointerCheck, 4> &getChecks() const {
> > +  const SmallVectorImpl<RuntimePointerCheck> &getChecks() const {
> Shouldn't this return ArrayRef<> even?
>

Yeah I guess that would be even better!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200722/bd7c9133/attachment.html>


More information about the llvm-commits mailing list