<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 22, 2020 at 11:49 AM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On Wed, Jul 22, 2020 at 1:40 PM Florian Hahn via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
><br>
> Author: Florian Hahn<br>
> Date: 2020-07-22T11:40:07+01:00<br>
> New Revision: cf9fa2aa018105313efc77c7fb6c5d9dce700297<br>
><br>
> URL: <a href="https://github.com/llvm/llvm-project/commit/cf9fa2aa018105313efc77c7fb6c5d9dce700297" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/cf9fa2aa018105313efc77c7fb6c5d9dce700297</a><br>
> DIFF: <a href="https://github.com/llvm/llvm-project/commit/cf9fa2aa018105313efc77c7fb6c5d9dce700297.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/cf9fa2aa018105313efc77c7fb6c5d9dce700297.diff</a><br>
><br>
> LOG: [lAA] Return SmallVectorImpl& instead of SmallVector& (NFC).<br>
><br>
> Added:<br>
><br>
><br>
> Modified:<br>
>     llvm/include/llvm/Analysis/LoopAccessAnalysis.h<br>
><br>
> Removed:<br>
><br>
><br>
><br>
> ################################################################################<br>
> diff  --git a/llvm/include/llvm/Analysis/LoopAccessAnalysis.h b/llvm/include/llvm/Analysis/LoopAccessAnalysis.h<br>
> index a5237e9ba59e..663b9c9935db 100644<br>
> --- a/llvm/include/llvm/Analysis/LoopAccessAnalysis.h<br>
> +++ b/llvm/include/llvm/Analysis/LoopAccessAnalysis.h<br>
> @@ -418,7 +418,7 @@ class RuntimePointerChecking {<br>
>                        bool UseDependencies);<br>
><br>
>    /// Returns the checks that generateChecks created.<br>
> -  const SmallVector<RuntimePointerCheck, 4> &getChecks() const {<br>
> +  const SmallVectorImpl<RuntimePointerCheck> &getChecks() const {<br>
Shouldn't this return ArrayRef<> even?<br></blockquote><div><br></div><div>Yeah I guess that would be even better! </div></div><div dir="ltr" class="gmail_signature"><br></div></div>