[PATCH] D83465: Encode alignment attribute for `atomicrmw`

[JF Bastien via Phabricator via llvm-commits]

jfb added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:5083
+      if (Record.size() == 7)
+        Alignment = Align(1ULL << Record[6]);
+      else
----------------
I think you want this instead:
```

      MaybeAlign Align;
      if (Error Err = parseAlignmentValue(Record[6], Align))
        return Err;
```
?


================
Comment at: llvm/test/Bitcode/compatibility.ll:756
+  %atomicrmw.umin = atomicrmw volatile umin i32* %word, i32 22 syncscope("singlethread") monotonic, align 4
+  ; CHECK: %atomicrmw.umin = atomicrmw volatile umin i32* %word, i32 22 syncscope("singlethread") monotonic, align 4
   fence acquire
----------------
I think you still need tests *without* alignment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83465/new/

https://reviews.llvm.org/D83465