[PATCH] D83452: [DWARFYAML] Use override instead of virtual for better safety.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 02:27:38 PDT 2020


Higuoxing added a comment.

In D83452#2141201 <https://reviews.llvm.org/D83452#2141201>, @jhenderson wrote:

> > We should override those functions rather than declare a new set of virtual functions for better safety.
>
> We're still not declaring a new set of virtual functions. Just say something like "We should use the modern override keyword instead of virtual for virtual functions in subclasses."


Thanks a lot! I've changed the description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83452/new/

https://reviews.llvm.org/D83452





More information about the llvm-commits mailing list