[PATCH] D83452: [DWARFYAML] Use override instead of virtual for better safety.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 02:24:01 PDT 2020


jhenderson added a comment.

> We should override those functions rather than declare a new set of virtual functions for better safety.

We're still not declaring a new set of virtual functions. Just say something like "We should use the modern override keyword instead of virtual for virtual functions in subclasses."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83452/new/

https://reviews.llvm.org/D83452





More information about the llvm-commits mailing list