[PATCH] D79978: Call Frame Information (CFI) Handling for Basic Block Sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

I haven't looked into the details, but the test suggests that the patch is wrong:

          .section        .text,"ax", at progbits,unique,2
  _Z2f3b.2:                               # %if.end
          .cfi_startproc
          .cfi_def_cfa %rbp, 16    #  this should inserted after addq $16, %rsp
          .cfi_offset %rbp, -16    # this should be after .cfi_def_cfa %rbp, 16
          addq    $16, %rsp
          popq    %rbp
          .cfi_def_cfa %rsp, 8
          retq


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79978/new/

https://reviews.llvm.org/D79978