[PATCH] D79978: Call Frame Information (CFI) Handling for Basic Block Sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D79978#2140575 <https://reviews.llvm.org/D79978#2140575>, @tmsriram wrote:

> In D79978#2138208 <https://reviews.llvm.org/D79978#2138208>, @MaskRay wrote:
>
> > I have studied CFIInstrInserter in May. If you don't mind, please give me some time to review as well.
> >
> > For `basic-block-sections-cfiinstr_1.ll`, have you considered places like `CodeGen/X86/cfi-inserter-*`? You may even create a subdirectory there.
> >  `_1` is not very common. `-1` is more common.
>
>
> Done.
>
> > `curl -L 'https://reviews.llvm.org/D79978?download=1'` does not have a/ or b/ prefix. I think that may be why `arc patch D79978` cannot apply the patch.
> >  Can you upload a diff with either `arc diff`, git format-patch -1 or `git diff 'HEAD^'`? Thanks.
>
> Uploaded after git diff HEAD^.  Please see if this works.


Your diff includes:

  --- llvm/include/llvm/CodeGen/TargetFrameLowering.h
  +++ llvm/include/llvm/CodeGen/TargetFrameLowering.h

`git diff 'HEAD^'` includes a prefix:

  --- c/llvm/include/llvm/CodeGen/TargetFrameLowering.h
  +++ w/llvm/include/llvm/CodeGen/TargetFrameLowering.h


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79978/new/

https://reviews.llvm.org/D79978