[PATCH] D82387: [flang] add RTBuilder

[Eric Christopher via llvm-commits]

Sent out https://reviews.llvm.org/D83397

-eric

On Tue, Jul 7, 2020 at 10:45 AM Eric Christopher <echristo at gmail.com> wrote:

> ... you're the one that put the review up and didn't credit anyone else.
> Can you fix this then?
>
> Thanks.
>
> -eric
>
> On Tue, Jul 7, 2020 at 10:10 AM Eric Schweitz (PGI) <
> eric.schweitz at pgroup.com> wrote:
>
>> The original author of this particular code knows of the issue, but is
>> currently out on vacation.
>>
>>
>>
>> Thanks,
>>
>> Eric
>>
>>
>>
>> *From:* Eric Christopher <echristo at gmail.com>
>> *Sent:* Monday, July 6, 2020 2:40 PM
>> *To:* reviews+D82387+public+36dcff9b060bae84 at reviews.llvm.org
>> *Cc:* Eric Schweitz (PGI) <eric.schweitz at pgroup.com>; Jean Perier <
>> jperier at nvidia.com>; Steve Scalpone <sscalpone at nvidia.com>;
>> kiranchandramohan at gmail.com; clementval at gmail.com; Doerfert, Johannes <
>> jdoerfert at anl.gov>; David Truby <david.truby at arm.com>;
>> gsocsameeran at gmail.com; River Riddle <riddleriver at gmail.com>;
>> stephen.neuendorffer at gmail.com; llvm-commits <llvm-commits at lists.llvm.org>;
>> 88888yl at gmail.com; Samuel.j.knapp at btinternet.com; Peter Steinfeld <
>> psteinfeld at nvidia.com>; aperry at lanl.gov; Timothy Keith <tkeith at nvidia.com>;
>> Sourabh Singh Tomar <sourabhsingh.tomar at amd.com>; Isuru Fernando <
>> isuruf at gmail.com>; Valentin Churavy <v.churavy at gmail.com>;
>> uday at polymagelabs.com
>> *Subject:* Re: [PATCH] D82387: [flang] add RTBuilder
>>
>>
>>
>> Agreed. This should be fixed :)
>>
>>
>>
>> -eric
>>
>>
>>
>> On Mon, Jul 6, 2020 at 12:54 PM David Truby via Phabricator <
>> reviews at reviews.llvm.org> wrote:
>>
>> DavidTruby added a comment.
>>
>> Is there a reason to use `float _Complex` here at all? The C++ standard
>> (29.5.4 of C++17) guarantees that `std::complex<float>` and `float
>> _Complex` are layout compatible and can be reinterpret_casted to each other
>> so even if these functions are intended to be callable from C/interoperable
>> with _Complex in C code, it'd be better to use std::complex<float> on the
>> C++ side.
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D82387/new/
>>
>> https://reviews.llvm.org/D82387
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200708/7d0f6541/attachment.html>