<div dir="ltr">Sent out <a href="https://reviews.llvm.org/D83397">https://reviews.llvm.org/D83397</a><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 7, 2020 at 10:45 AM Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">... you're the one that put the review up and didn't credit anyone else. Can you fix this then?<div><br></div><div>Thanks.</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 7, 2020 at 10:10 AM Eric Schweitz (PGI) <<a href="mailto:eric.schweitz@pgroup.com" target="_blank">eric.schweitz@pgroup.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div>
<p class="MsoNormal">The original author of this particular code knows of the issue, but is currently out on vacation.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
<p class="MsoNormal">Eric<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> <br>
<b>Sent:</b> Monday, July 6, 2020 2:40 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD82387%2Bpublic%2B36dcff9b060bae84@reviews.llvm.org" target="_blank">reviews+D82387+public+36dcff9b060bae84@reviews.llvm.org</a><br>
<b>Cc:</b> Eric Schweitz (PGI) <<a href="mailto:eric.schweitz@pgroup.com" target="_blank">eric.schweitz@pgroup.com</a>>; Jean Perier <<a href="mailto:jperier@nvidia.com" target="_blank">jperier@nvidia.com</a>>; Steve Scalpone <<a href="mailto:sscalpone@nvidia.com" target="_blank">sscalpone@nvidia.com</a>>; <a href="mailto:kiranchandramohan@gmail.com" target="_blank">kiranchandramohan@gmail.com</a>; <a href="mailto:clementval@gmail.com" target="_blank">clementval@gmail.com</a>; Doerfert, Johannes <<a href="mailto:jdoerfert@anl.gov" target="_blank">jdoerfert@anl.gov</a>>; David Truby <<a href="mailto:david.truby@arm.com" target="_blank">david.truby@arm.com</a>>;
<a href="mailto:gsocsameeran@gmail.com" target="_blank">gsocsameeran@gmail.com</a>; River Riddle <<a href="mailto:riddleriver@gmail.com" target="_blank">riddleriver@gmail.com</a>>; <a href="mailto:stephen.neuendorffer@gmail.com" target="_blank">stephen.neuendorffer@gmail.com</a>; llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>; <a href="mailto:88888yl@gmail.com" target="_blank">88888yl@gmail.com</a>; <a href="mailto:Samuel.j.knapp@btinternet.com" target="_blank">Samuel.j.knapp@btinternet.com</a>; Peter Steinfeld <<a href="mailto:psteinfeld@nvidia.com" target="_blank">psteinfeld@nvidia.com</a>>; <a href="mailto:aperry@lanl.gov" target="_blank">aperry@lanl.gov</a>; Timothy Keith
<<a href="mailto:tkeith@nvidia.com" target="_blank">tkeith@nvidia.com</a>>; Sourabh Singh Tomar <<a href="mailto:sourabhsingh.tomar@amd.com" target="_blank">sourabhsingh.tomar@amd.com</a>>; Isuru Fernando <<a href="mailto:isuruf@gmail.com" target="_blank">isuruf@gmail.com</a>>; Valentin Churavy <<a href="mailto:v.churavy@gmail.com" target="_blank">v.churavy@gmail.com</a>>; <a href="mailto:uday@polymagelabs.com" target="_blank">uday@polymagelabs.com</a><br>
<b>Subject:</b> Re: [PATCH] D82387: [flang] add RTBuilder<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Agreed. This should be fixed :)<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">-eric<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Mon, Jul 6, 2020 at 12:54 PM David Truby via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12pt">DavidTruby added a comment.<br>
<br>
Is there a reason to use `float _Complex` here at all? The C++ standard (29.5.4 of C++17) guarantees that `std::complex<float>` and `float _Complex` are layout compatible and can be reinterpret_casted to each other so even if these functions are intended to
be callable from C/interoperable with _Complex in C code, it'd be better to use std::complex<float> on the C++ side.<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D82387/new/" target="_blank">https://reviews.llvm.org/D82387/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D82387" target="_blank">https://reviews.llvm.org/D82387</a><br>
<br>
<br>
<u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</blockquote></div>
</blockquote></div>